fix(dashboard): address observability review findings
This commit is contained in:
parent
2d2b905d18
commit
bfb9a91e49
11 changed files with 188 additions and 10 deletions
|
|
@ -113,12 +113,12 @@
|
|||
overflow: hidden;
|
||||
}
|
||||
|
||||
.dashboard-frame__panels :global(.service-panel[data-model-id="runtime-health"]) {
|
||||
.dashboard-frame__panels :global(.service-panel[data-layout="grid"]) {
|
||||
grid-column: 1 / -1;
|
||||
}
|
||||
|
||||
.dashboard-frame__panels
|
||||
:global(.service-panel[data-model-id="runtime-health"] .panel__body) {
|
||||
:global(.service-panel[data-layout="grid"] .panel__body) {
|
||||
grid-template-columns: repeat(4, minmax(0, 1fr));
|
||||
}
|
||||
|
||||
|
|
@ -147,7 +147,7 @@
|
|||
}
|
||||
|
||||
.dashboard-frame__panels
|
||||
:global(.service-panel[data-model-id="runtime-health"] .panel__body) {
|
||||
:global(.service-panel[data-layout="grid"] .panel__body) {
|
||||
grid-template-columns: 1fr;
|
||||
}
|
||||
}
|
||||
|
|
|
|||
|
|
@ -7,7 +7,7 @@
|
|||
let { group }: { group: UiServiceGroup } = $props();
|
||||
</script>
|
||||
|
||||
<div class="service-panel" data-model-id={group.id}>
|
||||
<div class="service-panel" data-layout={group.layout || "list"} data-model-id={group.id}>
|
||||
<Panel title={group.title}>
|
||||
{#if group.summary?.length}
|
||||
<StatusStrip id={`${group.id}:summary`} items={group.summary} compact />
|
||||
|
|
|
|||
|
|
@ -25,6 +25,9 @@ describe("dashboard model renderer", () => {
|
|||
expect(dashboard.serviceGroups.map((group) => group.id)).toEqual(
|
||||
dimensionLabDashboardFixture.layout.serviceGroups,
|
||||
);
|
||||
expect(dashboard.serviceGroups.find((group) => group.id === "runtime-health")?.layout).toBe(
|
||||
"grid",
|
||||
);
|
||||
expect(dashboard.modules.map((module) => module.id)).toEqual([
|
||||
"weather-amsterdam",
|
||||
"runtime-health-summary",
|
||||
|
|
|
|||
|
|
@ -58,6 +58,7 @@ function telemetryToUi(card: TelemetryCard): UiTelemetryCard {
|
|||
function serviceGroupToUi(group: ServiceGroup): UiServiceGroup {
|
||||
return {
|
||||
id: group.id,
|
||||
layout: group.layout,
|
||||
title: group.title,
|
||||
services: group.services.map(serviceToUi),
|
||||
};
|
||||
|
|
|
|||
|
|
@ -52,6 +52,7 @@ export interface UiServiceRow {
|
|||
|
||||
export interface UiServiceGroup {
|
||||
id: string;
|
||||
layout?: "grid" | "list";
|
||||
title: string;
|
||||
services: UiServiceRow[];
|
||||
summary?: UiStatusItem[];
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue