From c2fb20b066e080ab8c623ecdc7f0bd153a1683e2 Mon Sep 17 00:00:00 2001
From: vince <vince@linux-infra.dimensionlab.net>
Date: Thu, 18 Jun 2026 19:29:30 +0200
Subject: [PATCH] fix: complete model renderer states and ids

---
 src/lib/server/dashboard.ts                 |  8 ++++++
 src/lib/ui/components/DashboardFrame.svelte |  2 +-
 src/lib/ui/components/ServicePanel.svelte   |  8 ++++--
 src/lib/ui/components/StatusStrip.svelte    |  4 ++-
 src/lib/ui/components/render.test.ts        | 11 +++++++
 src/lib/ui/fixtures.ts                      |  2 ++
 src/lib/ui/model-renderer.test.ts           |  1 +
 src/lib/ui/model-renderer.ts                |  1 +
 src/lib/ui/types.ts                         |  1 +
 src/routes/+page.svelte                     | 21 ++++++++++++--
 src/routes/page.test.ts                     | 32 +++++++++++++++++++++
 11 files changed, 84 insertions(+), 7 deletions(-)

diff --git a/src/lib/server/dashboard.ts b/src/lib/server/dashboard.ts
index c470399..6a55985 100644
--- a/src/lib/server/dashboard.ts
+++ b/src/lib/server/dashboard.ts
@@ -10,6 +10,7 @@ import { UnsupportedDashboardModelVersionError } from "$lib/server/db/model-migr
 export type DashboardRuntimeState =
   | DashboardRuntimeEmpty
   | DashboardRuntimeInvalid
+  | DashboardRuntimeLoading
   | DashboardRuntimeReady;
 
 export interface DashboardRuntimeReady {
@@ -26,6 +27,13 @@ export interface DashboardRuntimeEmpty {
   message: string;
 }
 
+export interface DashboardRuntimeLoading {
+  state: "loading";
+  title: string;
+  subtitle: string;
+  message: string;
+}
+
 export interface DashboardRuntimeInvalid {
   state: "invalid";
   title: string;
diff --git a/src/lib/ui/components/DashboardFrame.svelte b/src/lib/ui/components/DashboardFrame.svelte
index 0a76f67..4a4fff8 100644
--- a/src/lib/ui/components/DashboardFrame.svelte
+++ b/src/lib/ui/components/DashboardFrame.svelte
@@ -44,7 +44,7 @@
     {/each}
   </section>
 
-  <StatusStrip items={dashboard.statusItems} />
+  <StatusStrip id={dashboard.statusStripId} items={dashboard.statusItems} />
 </main>
 
 <style>
diff --git a/src/lib/ui/components/ServicePanel.svelte b/src/lib/ui/components/ServicePanel.svelte
index c292535..0b997d7 100644
--- a/src/lib/ui/components/ServicePanel.svelte
+++ b/src/lib/ui/components/ServicePanel.svelte
@@ -7,11 +7,13 @@
   let { group }: { group: UiServiceGroup } = $props();
 </script>
 
-<Panel title={group.title}>
+<div class="service-panel" data-model-id={group.id}>
+  <Panel title={group.title}>
   {#if group.summary?.length}
-    <StatusStrip items={group.summary} compact />
+    <StatusStrip id={`${group.id}:summary`} items={group.summary} compact />
   {/if}
   {#each group.services as service (service.id)}
     <ServiceRow {service} />
   {/each}
-</Panel>
+  </Panel>
+</div>
diff --git a/src/lib/ui/components/StatusStrip.svelte b/src/lib/ui/components/StatusStrip.svelte
index 6a2bcf1..a11b786 100644
--- a/src/lib/ui/components/StatusStrip.svelte
+++ b/src/lib/ui/components/StatusStrip.svelte
@@ -3,15 +3,17 @@
   import FooterCell from "./FooterCell.svelte";
 
   let {
+    id,
     items,
     compact = false,
   }: {
+    id?: string;
     items: UiStatusItem[];
     compact?: boolean;
   } = $props();
 </script>
 
-<section class="status-strip" data-compact={compact}>
+<section class="status-strip" data-compact={compact} data-model-id={id}>
   {#each items as item (item.id)}
     <FooterCell {item} />
   {/each}
diff --git a/src/lib/ui/components/render.test.ts b/src/lib/ui/components/render.test.ts
index bf1e98f..fa55ecb 100644
--- a/src/lib/ui/components/render.test.ts
+++ b/src/lib/ui/components/render.test.ts
@@ -70,6 +70,17 @@ describe("dashboard UI components", () => {
     expect(footer.body).toContain("href=\"https://example.test/status\"");
   });
 
+  test("renders stable model IDs on group and status containers", () => {
+    const { body } = render(DashboardFrame, {
+      props: {
+        dashboard: dashboardPreviewFixtures.primary,
+      },
+    });
+
+    expect(body).toContain("data-model-id=\"queue-workers\"");
+    expect(body).toContain("data-model-id=\"dashboard-status\"");
+  });
+
   test("does not render progress bars for non-percent metrics without explicit progress", () => {
     const withoutProgress = render(TelemetryCard, {
       props: {
diff --git a/src/lib/ui/fixtures.ts b/src/lib/ui/fixtures.ts
index 54f8b48..b8008c1 100644
--- a/src/lib/ui/fixtures.ts
+++ b/src/lib/ui/fixtures.ts
@@ -58,6 +58,7 @@ export const dashboardPreviewFixtures: Record<string, UiDashboardPreview> = {
       { id: "uptime", label: "Uptime", value: "14d 08h", severity: "neutral" },
       { id: "refresh", label: "Refresh", value: "15s", severity: "neutral" },
     ],
+    statusStripId: "dashboard-status",
   },
   secondary: {
     eyebrow: "Support Surface",
@@ -96,6 +97,7 @@ export const dashboardPreviewFixtures: Record<string, UiDashboardPreview> = {
       { id: "handoff", label: "Handoff", value: "Pending", severity: "warning" },
       { id: "routing", label: "Routing", value: "Manual", severity: "neutral" },
     ],
+    statusStripId: "support-status",
   },
 };
 
diff --git a/src/lib/ui/model-renderer.test.ts b/src/lib/ui/model-renderer.test.ts
index cde1f2c..def9d50 100644
--- a/src/lib/ui/model-renderer.test.ts
+++ b/src/lib/ui/model-renderer.test.ts
@@ -35,6 +35,7 @@ describe("dashboard model renderer", () => {
       "footer-status:uptime",
       "footer-status:load-avg",
     ]);
+    expect(dashboard.statusStripId).toBe("footer-status");
   });
 
   test("projects a second fixture through the same mapper", () => {
diff --git a/src/lib/ui/model-renderer.ts b/src/lib/ui/model-renderer.ts
index 468b4b1..96e58f3 100644
--- a/src/lib/ui/model-renderer.ts
+++ b/src/lib/ui/model-renderer.ts
@@ -38,6 +38,7 @@ export function dashboardDocumentToUiDashboard(
       document.layout.statusStrips,
       document.statusStrips,
     ).flatMap(statusStripToUiItems),
+    statusStripId: document.layout.statusStrips[0],
   };
 }
 
diff --git a/src/lib/ui/types.ts b/src/lib/ui/types.ts
index 1844491..55d8aee 100644
--- a/src/lib/ui/types.ts
+++ b/src/lib/ui/types.ts
@@ -83,4 +83,5 @@ export interface UiDashboardPreview {
   serviceGroups: UiServiceGroup[];
   modules: UiModuleBlock[];
   statusItems: UiStatusItem[];
+  statusStripId?: string;
 }
diff --git a/src/routes/+page.svelte b/src/routes/+page.svelte
index b544aa9..b4c4f11 100644
--- a/src/routes/+page.svelte
+++ b/src/routes/+page.svelte
@@ -43,8 +43,8 @@
     <SystemState
       title={stateTitle}
       detail={`${stateSubtitle}: ${stateMessage}`}
-      severity={data.dashboard.state === "invalid" ? "danger" : "stale"}
-      icon={data.dashboard.state === "invalid" ? "mdi:file-alert-outline" : "mdi:tray"}
+      severity={stateSeverity(data.dashboard.state)}
+      icon={stateIcon(data.dashboard.state)}
     />
     {#if stateErrors.length}
       <ul aria-label="Validation errors">
@@ -78,3 +78,20 @@
     padding: var(--ui-space-3);
   }
 </style>
+
+<script lang="ts" module>
+  import type { DashboardRuntimeState } from "$lib/server/dashboard";
+  import type { UiSeverity } from "$lib/ui";
+
+  function stateSeverity(state: DashboardRuntimeState["state"]): UiSeverity {
+    if (state === "invalid") return "danger";
+    if (state === "loading") return "loading";
+    return "stale";
+  }
+
+  function stateIcon(state: DashboardRuntimeState["state"]): string {
+    if (state === "invalid") return "mdi:file-alert-outline";
+    if (state === "loading") return "mdi:progress-clock";
+    return "mdi:tray";
+  }
+</script>
diff --git a/src/routes/page.test.ts b/src/routes/page.test.ts
index bc4fefc..c302884 100644
--- a/src/routes/page.test.ts
+++ b/src/routes/page.test.ts
@@ -45,4 +45,36 @@ describe("home page model renderer", () => {
     expect(body).toContain("Validation failed");
     expect(body).toContain("Dashboard document is invalid.");
   });
+
+  test("renders empty and loading model states without crashing", () => {
+    const empty = render(Page, {
+      props: {
+        data: {
+          dashboard: {
+            state: "empty",
+            title: "No Dashboard Model",
+            subtitle: "No active document",
+            message: "No validated dashboard document is active yet.",
+          },
+        },
+      },
+    });
+    const loading = render(Page, {
+      props: {
+        data: {
+          dashboard: {
+            state: "loading",
+            title: "Loading Dashboard",
+            subtitle: "Fetching active model",
+            message: "Waiting for the active dashboard document.",
+          },
+        },
+      },
+    });
+
+    expect(empty.body).toContain("No Dashboard Model");
+    expect(empty.body).toContain("No active document");
+    expect(loading.body).toContain("Loading Dashboard");
+    expect(loading.body).toContain("Fetching active model");
+  });
 });